Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: fix description width for unknown total #1032

Merged
merged 1 commit into from Sep 27, 2020
Merged

Conversation

casperdcl
Copy link
Sponsor Member

@casperdcl casperdcl commented Sep 13, 2020

Unfortunately this may break code of a handful of people parsing tqdm.notebook.tqdm.container.children since it's changed from [IProgress(), HTML()] to [HTML(), IProgress(), HTML()]. Technically a breaking change but don't think it affects the vast majority of users.

@casperdcl casperdcl added p2-bug-warning ⚠ Visual output bad submodule-notebook 📓 Much web such IDE c3-small 🕒 Complexity medium labels Sep 13, 2020
@casperdcl casperdcl added this to the Non-breaking milestone Sep 13, 2020
@casperdcl casperdcl self-assigned this Sep 13, 2020
@casperdcl casperdcl added this to Next Release in Casper Sep 13, 2020
@casperdcl casperdcl added the to-merge ↰ Imminent label Sep 13, 2020
@casperdcl casperdcl linked an issue Sep 13, 2020 that may be closed by this pull request
8 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #1032 into devel will increase coverage by 2.03%.
The diff coverage is 83.93%.

@@            Coverage Diff             @@
##            devel    #1032      +/-   ##
==========================================
+ Coverage   85.37%   87.41%   +2.03%     
==========================================
  Files          22       22              
  Lines        1279     1390     +111     
  Branches      218      235      +17     
==========================================
+ Hits         1092     1215     +123     
+ Misses        166      151      -15     
- Partials       21       24       +3     

@casperdcl casperdcl mentioned this pull request Sep 27, 2020
@casperdcl casperdcl merged commit e835860 into devel Sep 27, 2020
Casper automation moved this from Next Release to Done Sep 27, 2020
@casperdcl casperdcl deleted the notebook-nototal branch September 28, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3-small 🕒 Complexity medium p2-bug-warning ⚠ Visual output bad submodule-notebook 📓 Much web such IDE to-merge ↰ Imminent
Projects
Casper
  
Done
Development

Successfully merging this pull request may close these issues.

[JupyterLab] tqdm.auto visual output bug 4.49.0
2 participants