Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --sdistonly behaviour #2775

Merged
merged 1 commit into from Dec 25, 2022
Merged

Fix --sdistonly behaviour #2775

merged 1 commit into from Dec 25, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Dec 25, 2022

Thanks for contribution

Closes #2653
Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@gaborbernat gaborbernat merged commit a36ff9d into tox-dev:main Dec 25, 2022
@q0w
Copy link
Contributor Author

q0w commented Dec 25, 2022

@gaborbernat are you sure the fix is correct? Maybe i am missing something?

@gaborbernat
Copy link
Member

I think it's fine. The main difference between this option and no test is that this option does not install the package and its dependencies, just build the package.

descope bot added a commit to descope/django-descope that referenced this pull request Jan 9, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox) | dev | patch | `4.0.16` ->
`4.0.17` | `4.2.6` (+12) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.0.17`](https://togithub.com/tox-dev/tox/releases/tag/4.0.17)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.0.16...4.0.17)

#### What's Changed

- Suppress a report output when verbosity = 0. by
[@&#8203;q0w](https://togithub.com/q0w) in
[tox-dev/tox#2774
- Fix --sdistonly behaviour by [@&#8203;q0w](https://togithub.com/q0w)
in
[tox-dev/tox#2775
- Override toxworkdir with --workdir. by
[@&#8203;q0w](https://togithub.com/q0w) in
[tox-dev/tox#2776

#### New Contributors

- [@&#8203;q0w](https://togithub.com/q0w) made their first contribution
in
[tox-dev/tox#2774

**Full Changelog**:
tox-dev/tox@4.0.16...4.0.17

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMCJ9-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdistonly not working
2 participants