Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_sequential: resolve() the system_executable #2751

Merged
merged 1 commit into from Dec 19, 2022

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Dec 19, 2022

When the _base_executable is a hardlink (macOS homebrew), then the virtualenv PythonInfo.current_system() call might not return the same path as tox's PythonInfo.interpreter, even though they would be pointing to the same file.

fix issue #2720

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

When the _base_executable is a hardlink (macOS homebrew), then the
virtualenv `PythonInfo.current_system()` call might not return the same
path as tox's PythonInfo.interpreter, even though they would be pointing
to the same file.

fix issue tox-dev#2720
@masenf masenf marked this pull request as ready for review December 19, 2022 03:21
@gaborbernat gaborbernat merged commit 9972a82 into tox-dev:main Dec 19, 2022
descope bot added a commit to descope/django-descope that referenced this pull request Jan 3, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox) | dev | patch | `4.0.14` ->
`4.0.15` | `4.1.3` (+7) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.0.15`](https://togithub.com/tox-dev/tox/releases/tag/4.0.15)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.0.14...4.0.15)

#### What's Changed

- test_sequential: resolve() the system_executable by
[@&#8203;masenf](https://togithub.com/masenf) in
[tox-dev/tox#2751
- Fix provisioning by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[tox-dev/tox#2750
- Fix complex negative factor filters not working by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[tox-dev/tox#2757

**Full Changelog**:
tox-dev/tox@4.0.14...4.0.15

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMCJ9-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
@masenf masenf deleted the python-info-2720 branch January 18, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants