Provision lock #2516
Merged
Provision lock #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kick off two processes that need to provision the tox environment and ensure they don't stomp on each other in the process.
avoid race condition when `.tox` environment needs to be provisioned
masenf
requested review from
gaborbernat,
asottile,
obestwalter and
jugmac00
as code owners
gaborbernat
reviewed
Oct 25, 2022
|
@gaborbernat if the change itself looks reasonable, I will fix the CI issues and update change log and contributors. This came out of a bug discovered "at work", I'll circle back on it today and clean up. |
subprocess.Popen didn't accept the `encoding` kwarg. rather than attempting other tricks, just match the output as an explicit bytestring, which will work on any interpreter.
as per PR checklist
add changelog information about issue tox-dev#2515
rst ``code`` is two backticks.................................Failed - hook id: rst-backticks - exit code: 1
|
@gaborbernat i believe this is now ready for review |
gaborbernat
approved these changes
Oct 25, 2022
This was referenced Aug 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2515
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc-- by :user:`<your username>`.CONTRIBUTORS(preserving alphabetical order)