Use tomllib from the standard library on Python 3.11+ #2463

hroncok · 2022-07-21T14:11:35Z

Fallback to tomli, which has the same API.

Fixes #2462

Contribution checklist:

(also see CONTRIBUTING.rst for details)

wrote descriptive pull request text
added/updated test(s)
updated/extended the documentation
added relevant issue keyword in message body
added news fragment in changelog folder
- fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
- <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
- if PR has no issue: consider creating one first or change it to the PR number after creating the PR
- "sign" fragment with -- by :user:`<your username>`.
- please, use full sentences with correct case and punctuation, for example:
```
Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
```
- also see examples
added yourself to CONTRIBUTORS (preserving alphabetical order)

jugmac00 · 2022-07-25T09:02:23Z

Looks good to me!

But neither tox nor gh actions run Python 3.11.

@gaborbernat What do you think? Are you ok with the changes? This would mean we need to run CI with Python 3.11 beta.

gaborbernat · 2022-07-25T18:17:32Z

But neither tox nor gh actions run Python 3.11.

Yeah, we need to change that before we merge this. I'll add 3.11 to virtualenv today and then move to tox.

Fallback to tomli, which has the same API. Fixes tox-dev#2462

for more information, see https://pre-commit.ci

for more information, see https://pre-commit.ci Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>

hroncok · 2022-08-22T07:44:16Z

Is the Python 2 compatibility no longer a concern?

jugmac00 · 2022-08-22T07:45:57Z

Is the Python 2 compatibility no longer a concern?

The information is split between the issue and the pr.

@gaborbernat The Python 2 comp was discussed at #2462 (comment)

gaborbernat · 2022-08-22T17:38:51Z

Seems we'll need to fallback to toml on python 2.

hroncok · 2022-08-22T17:59:28Z

Yes. See my fixup: Fallback to toml, not tomli, for Python 2 support commit which can still be seen here at github. It seems to have been erased away.

gaborbernat · 2022-08-22T18:09:26Z

Because you've fallen back to toml on Python 3.11 or less and not just Python 2. 🤔

hroncok · 2022-08-22T18:11:01Z

So you'd prefer a three-way split? I can do that, I just considered it a bit redundant.

gaborbernat · 2022-08-22T18:19:11Z

So you'd prefer a three-way split? I can do that, I just considered it a bit redundant.

Yes.

src/tox/config/__init__.py

setup.cfg

for more information, see https://pre-commit.ci

setup.cfg

hroncok · 2022-08-22T19:49:49Z

Looks like 3.5 will also need toml. Will update this later today.

hroncok · 2022-08-22T20:59:19Z

This seems to work. At least on cpythons.

Let me know if you prefer to use toml also on 3.6 and pin tomli to 2+.

Let me know if you want me to rebase or squash somehow.

docs/changelog/2463.feature.rst

Co-authored-by: Miro Hrončok <miro@hroncok.cz>

setup.cfg

hroncok · 2022-08-23T12:12:30Z

Let me know if you prefer to use toml also on 3.6 and pin tomli to 2+.

I've done that now. Feel free to revert the commit.

…eview)

527: Bump tox from 3.25.1 to 3.26.0 r=alallema a=dependabot[bot] Bumps [tox](https://github.com/tox-dev/tox) from 3.25.1 to 3.26.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tox-dev/tox/releases">tox's releases</a>.</em></p> <blockquote> <h2>3.26.0</h2> <h2>What's Changed</h2> <ul> <li>release 3.25.1 by <a href="https://github.com/gaborbernat"><code>`@gaborbernat</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2451">tox-dev/tox#2451</a></li> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>`@pre-commit-ci</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2454">tox-dev/tox#2454</a></li> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>`@pre-commit-ci</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2465">tox-dev/tox#2465</a></li> <li>Check 3.11 support v3 by <a href="https://github.com/gaborbernat"><code>`@gaborbernat</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2468">tox-dev/tox#2468</a></li> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>`@pre-commit-ci</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2471">tox-dev/tox#2471</a></li> <li>Update CODEOWNERS by <a href="https://github.com/jugmac00"><code>`@jugmac00</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2472">tox-dev/tox#2472</a></li> <li>Fix fallback to "python" environment when "isolated_build = true" is set by <a href="https://github.com/Unrud"><code>`@Unrud</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2475">tox-dev/tox#2475</a></li> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>`@pre-commit-ci</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2477">tox-dev/tox#2477</a></li> <li>Use tomllib from the standard library on Python 3.11+ by <a href="https://github.com/hroncok"><code>`@hroncok</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2463">tox-dev/tox#2463</a></li> <li>[pre-commit.ci] pre-commit autoupdate by <a href="https://github.com/pre-commit-ci"><code>`@pre-commit-ci</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2485">tox-dev/tox#2485</a></li> <li>Fix SetuptoolsDeprecationWarning about using --global-option by <a href="https://github.com/adamchainz"><code>`@adamchainz</code></a>` in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2487">tox-dev/tox#2487</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Unrud"><code>`@Unrud</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/tox-dev/tox/pull/2475">tox-dev/tox#2475</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/tox-dev/tox/compare/3.25.1...3.26.0">https://github.com/tox-dev/tox/compare/3.25.1...3.26.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p> <blockquote> <h2>v3.26.0 (2022-09-07)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Fix fallback to <code>python</code> environment when <code>isolated_build = true</code> is set -- by :user:<code>Unrud</code> <code>[#2474](tox-dev/tox#2474) <https://github.com/tox-dev/tox/issues/2474></code>_</li> <li>Fixed <code>SetuptoolsDeprecationWarning</code> about using <code>--global-option</code> -- by :user:<code>adamchainz</code> <code>[#2478](tox-dev/tox#2478) <https://github.com/tox-dev/tox/issues/2478></code>_</li> </ul> <p>Features ^^^^^^^^</p> <ul> <li>Use <code>tomllib</code> on Python 3.11 or later and <code>tomli</code> instead of <code>toml</code> library on lower versions - by :user:<code>hroncok</code>. <code>[#2463](tox-dev/tox#2463) <https://github.com/tox-dev/tox/issues/2463></code>_</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tox-dev/tox/commit/672e133f1a23858ab9a4a9298d31c61e085702d3"><code>672e133</code></a> release 3.26.0</li> <li><a href="https://github.com/tox-dev/tox/commit/628964d2eb7b62791e4f7c7b336a077ebaf65d1a"><code>628964d</code></a> Fix SetuptoolsDeprecationWarning about using --global-option (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2487">#2487</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/fd58e735918d85fe27679a666db4273c00e698c4"><code>fd58e73</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2485">#2485</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/6b76e18fcaa7c9610b642555bcb94aab1d37f2b3"><code>6b76e18</code></a> Use tomllib from the standard library on Python 3.11+ (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2463">#2463</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/3d67ccc6b343bfb0dff04c09aaa7755cf18543e0"><code>3d67ccc</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2477">#2477</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/ff847c6d7439173cafd43bf7b6cde1497b61be18"><code>ff847c6</code></a> Fix fallback to "python" environment when "isolated_build = true" is set (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2475">#2475</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/82c26ed42b2b868b2a1e909af3453b95f277a670"><code>82c26ed</code></a> Update check.yml</li> <li><a href="https://github.com/tox-dev/tox/commit/a67d0c5b3af032999d5af43d21395d893b8078da"><code>a67d0c5</code></a> Update CODEOWNERS</li> <li><a href="https://github.com/tox-dev/tox/commit/de3c0239a72116d4d94fc73b8fcf157554af38b6"><code>de3c023</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2471">#2471</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/e826f4adec18005f7fa60623ffd178eb0d23d79b"><code>e826f4a</code></a> Check 3.11 support (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2468">#2468</a>)</li> <li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.25.1...3.26.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=tox&package-manager=pip&previous-version=3.25.1&new-version=3.26.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

hroncok mentioned this pull request Jul 21, 2022

Use tomllib from the standard library on Python 3.11+ #2462

Closed

hroncok and others added 3 commits August 21, 2022 11:22

Use tomllib from the standard library on Python 3.11+

f8d10c5

Fallback to tomli, which has the same API. Fixes tox-dev#2462

[pre-commit.ci] auto fixes from pre-commit.com hooks

b2bbc6e

for more information, see https://pre-commit.ci

fixup: Fallback to toml, not tomli, for Python 2 support

0ed31db

gaborbernat force-pushed the tomllib branch 3 times, most recently from 69af9dd to d85dac3 Compare August 21, 2022 18:32

psf-chronographer bot added the bot:chronographer:provided label Aug 21, 2022

[pre-commit.ci] auto fixes from pre-commit.com hooks

99dd844

for more information, see https://pre-commit.ci Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>

gaborbernat force-pushed the tomllib branch from 6d2b8b5 to 99dd844 Compare August 21, 2022 18:32

gaborbernat marked this pull request as ready for review August 21, 2022 18:34

gaborbernat requested review from gaborbernat, asottile, obestwalter and jugmac00 as code owners August 21, 2022 18:34

gaborbernat approved these changes Aug 21, 2022

View reviewed changes

gaborbernat requested changes Aug 22, 2022

View reviewed changes

src/tox/config/__init__.py Show resolved Hide resolved

setup.cfg Outdated Show resolved Hide resolved

hroncok added 2 commits August 22, 2022 21:28

Use toml/tomli/tomlib

6b36263

Use io.open once again for python 2

1869e11

hroncok force-pushed the tomllib branch from 2f80999 to 1869e11 Compare August 22, 2022 19:29

[pre-commit.ci] auto fixes from pre-commit.com hooks

89654f9

for more information, see https://pre-commit.ci

hroncok commented Aug 22, 2022

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

hroncok commented Aug 22, 2022

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

Make it install on older Python 3.6

65430ed

Use toml on 3.6 as well

9ab5f16

hroncok commented Aug 22, 2022

View reviewed changes

docs/changelog/2463.feature.rst Outdated Show resolved Hide resolved

Update docs/changelog/2463.feature.rst

0985069

Co-authored-by: Miro Hrončok <miro@hroncok.cz>

gaborbernat requested changes Aug 22, 2022

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

gaborbernat reviewed Aug 22, 2022

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

hroncok added 2 commits August 23, 2022 14:12

Pin toml to the latest (and probably last) version (as requested in r…

c369057

…eview)

Use toml on Python 3.6 as well, so we can pin tomli to 2.0.1+

98ae852

gaborbernat approved these changes Aug 23, 2022

View reviewed changes

gaborbernat merged commit 6b76e18 into tox-dev:master Aug 29, 2022

tjni mentioned this pull request Nov 1, 2022

python310Packages.tox: 3.26.0 -> 3.27.0 NixOS/nixpkgs#198874

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use tomllib from the standard library on Python 3.11+ #2463

Use tomllib from the standard library on Python 3.11+ #2463

hroncok commented Jul 21, 2022

jugmac00 commented Jul 25, 2022

gaborbernat commented Jul 25, 2022

hroncok commented Aug 22, 2022

jugmac00 commented Aug 22, 2022

gaborbernat commented Aug 22, 2022

hroncok commented Aug 22, 2022

gaborbernat commented Aug 22, 2022

hroncok commented Aug 22, 2022

gaborbernat commented Aug 22, 2022

hroncok commented Aug 22, 2022

hroncok commented Aug 22, 2022

hroncok commented Aug 23, 2022

Navigation Menu

Use tomllib from the standard library on Python 3.11+ #2463

Use tomllib from the standard library on Python 3.11+ #2463

Conversation

hroncok commented Jul 21, 2022

Contribution checklist:

jugmac00 commented Jul 25, 2022

gaborbernat commented Jul 25, 2022

hroncok commented Aug 22, 2022

jugmac00 commented Aug 22, 2022

gaborbernat commented Aug 22, 2022

hroncok commented Aug 22, 2022

gaborbernat commented Aug 22, 2022

hroncok commented Aug 22, 2022

gaborbernat commented Aug 22, 2022

hroncok commented Aug 22, 2022

hroncok commented Aug 22, 2022

hroncok commented Aug 23, 2022