Require space after colon before factor expansion #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this change fixes #2821. Now, there are other unit tests to adapt. On it... |
pdecat
commented
Jan 4, 2023
… it is the last character of the line
for more information, see https://pre-commit.ci
gaborbernat
approved these changes
Jan 5, 2023
pdecat
commented
Jan 5, 2023
| @@ -50,7 +50,7 @@ def expand_factors(value: str) -> Iterator[tuple[list[list[tuple[str, bool]]] | | |||
| for line in value.split("\n"): | |||
| factors: list[list[tuple[str, bool]]] | None = None | |||
| marker_at, content = line.find(":"), line | |||
| if marker_at != -1: | |||
| if marker_at != -1 and (len(line) == marker_at + 1 or line[marker_at + 1] == " "): | |||
There was a problem hiding this comment.
@gaborbernat Should tabs be accepted too?
descope bot
added a commit
to descope/django-descope
that referenced
this pull request
Jan 19, 2023
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch | `4.2.2` -> `4.2.3` | `4.3.5` (+10) | --- ### Release Notes <details> <summary>tox-dev/tox</summary> ### [`v4.2.3`](https://togithub.com/tox-dev/tox/releases/tag/4.2.3) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.2.2...4.2.3) #### What's Changed - Require space after colon before factor expansion by [@​pdecat](https://togithub.com/pdecat) in [tox-dev/tox#2822 - Fix devenv when package for env is wheel/editable by [@​gaborbernat](https://togithub.com/gaborbernat) in [tox-dev/tox#2820 **Full Changelog**: tox-dev/tox@4.2.2...4.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OS4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTkuMiJ9--> Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contribution
Please, make sure you address all the checklists (for details on how see
development documentation)!
tox -e fix)docs/changelogfolderResolves #2821, and probably also #2817