Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax test_list_installed_deps() to allow other packages #2796

Merged
merged 1 commit into from Dec 31, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Dec 31, 2022

Relax the check in test_list_installed_deps() to allow pip freeze to return other packages before pip. This is necessary if the Python interpreter vendors some packages itself, so that they are available even in fresh venv. This is the case e.g. for cffi in PyPy.

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix (it's a fix for the tests, so… ;-))
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Relax the check in `test_list_installed_deps()` to allow `pip freeze`
to return other packages before `pip`.  This is necessary
if the Python interpreter vendors some packages itself, so that they
are available even in fresh venv.  This is the case e.g. for cffi
in PyPy.
@gaborbernat gaborbernat merged commit bfba43c into tox-dev:main Dec 31, 2022
@mgorny
Copy link
Contributor Author

mgorny commented Dec 31, 2022

Thanks!

@mgorny mgorny deleted the pypy3-freeze-assert branch December 31, 2022 08:18
@gaborbernat gaborbernat mentioned this pull request Jan 2, 2023
descope bot added a commit to descope/django-descope that referenced this pull request Jan 16, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch |
`4.1.2` -> `4.1.3` | `4.3.2` (+11) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.1.3`](https://togithub.com/tox-dev/tox/releases/tag/4.1.3)

[Compare Source](https://togithub.com/tox-dev/tox/compare/4.1.2...4.1.3)

#### What's Changed

- Relax test_list_installed_deps() to allow other packages by
[@&#8203;mgorny](https://togithub.com/mgorny) in
[tox-dev/tox#2796
- Skip time-machine dep and spinner tests on PyPy by
[@&#8203;mgorny](https://togithub.com/mgorny) in
[tox-dev/tox#2797
- Reuse package_env with --installpkg by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[tox-dev/tox#2803
- issue 2695/tox4 install command breaking change docs by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[tox-dev/tox#2806
- Better message when command parsing on empty input by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[tox-dev/tox#2807

**Full Changelog**: tox-dev/tox@4.1.2...4.1.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OS4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTkuMiJ9-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants