Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging error with emoji in git branch name. #2790

Merged
merged 4 commits into from Dec 29, 2022

Conversation

jamwil
Copy link
Contributor

@jamwil jamwil commented Dec 29, 2022

Fixes a bug on Windows where the logger fails when environment variables with unicode emoji are passed to tox using set_env or pass_env. Resolves #2768.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@jamwil jamwil marked this pull request as ready for review December 29, 2022 22:11
@jamwil jamwil marked this pull request as draft December 29, 2022 22:12
@jamwil
Copy link
Contributor Author

jamwil commented Dec 29, 2022

Of course I accidentally commit my VS Code settings 🤦‍♂️

@jamwil jamwil marked this pull request as ready for review December 29, 2022 22:23
@gaborbernat gaborbernat merged commit b49d118 into tox-dev:main Dec 29, 2022
@jamwil jamwil deleted the fix-2768 branch December 29, 2022 23:42
descope bot added a commit to descope/django-descope that referenced this pull request Jan 13, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch |
`4.1.0` -> `4.1.1` | `4.2.8` (+10) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.1.1`](https://togithub.com/tox-dev/tox/releases/tag/4.1.1)

[Compare Source](https://togithub.com/tox-dev/tox/compare/4.1.0...4.1.1)

#### What's Changed

- Add faq entry about re-use of environments by
[@&#8203;jugmac00](https://togithub.com/jugmac00) in
[tox-dev/tox#2789
- Fix logging error with emoji in git branch name. by
[@&#8203;jamwil](https://togithub.com/jamwil) in
[tox-dev/tox#2790

**Full Changelog**: tox-dev/tox@4.1.0...4.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OS4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTkuMiJ9-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeEncodeError during install_deps with emoji in git branch name
2 participants