Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create temp_dir if not exists #2781

Merged
merged 25 commits into from Dec 28, 2022
Merged

Create temp_dir if not exists #2781

merged 25 commits into from Dec 28, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Dec 27, 2022

Thanks for contribution

Closes #2770
Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

gaborbernat
gaborbernat requested changes Dec 27, 2022
View reviewed changes
src/tox/config/sets.py Outdated Show resolved Hide resolved
gaborbernat
gaborbernat requested changes Dec 27, 2022
View reviewed changes
tests/config/test_sets.py Outdated Show resolved Hide resolved
@q0w q0w requested a review from gaborbernat December 27, 2022 01:53
gaborbernat
gaborbernat requested changes Dec 27, 2022
View reviewed changes
src/tox/config/sets.py Outdated Show resolved Hide resolved
gaborbernat
gaborbernat reviewed Dec 27, 2022
View reviewed changes
src/tox/tox_env/api.py Outdated Show resolved Hide resolved
@q0w q0w changed the title Create default temp_dir Create temp_dir if not exists Dec 27, 2022
@gaborbernat gaborbernat marked this pull request as draft December 27, 2022 03:13
@q0w

This comment was marked as outdated.

Sign in to view
@q0w

This comment was marked as outdated.

Sign in to view
@q0w q0w marked this pull request as ready for review December 27, 2022 10:57
gaborbernat
gaborbernat requested changes Dec 28, 2022
View reviewed changes
tests/tox_env/test_api.py Outdated Show resolved Hide resolved
tests/tox_env/test_api.py Outdated Show resolved Hide resolved
tests/tox_env/test_api.py Outdated Show resolved Hide resolved
tests/tox_env/test_api.py Outdated Show resolved Hide resolved
@q0w q0w marked this pull request as draft December 28, 2022 07:07
@q0w q0w marked this pull request as ready for review December 28, 2022 07:12
@gaborbernat gaborbernat merged commit 39dd2b6 into tox-dev:main Dec 28, 2022
@q0w q0w deleted the 2770 branch December 28, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

temp_dir does not exist
2 participants
@q0w @gaborbernat