Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox 4 ignores TOX_SKIP_ENV #2698

Closed
mgedmin opened this issue Dec 13, 2022 · 4 comments · Fixed by #2707
Closed

tox 4 ignores TOX_SKIP_ENV #2698

mgedmin opened this issue Dec 13, 2022 · 4 comments · Fixed by #2707
Labels
bug:minor does not affect many people or has no big impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.

Comments

@mgedmin
Copy link
Contributor

mgedmin commented Dec 13, 2022 •
edited

Issue

My make release for gitlab-trace runs TOX_SKIP_ENV=check-manifest tox -p auto. This worked with tox 3.x. It now fails in tox 4, because it doesn't skip the check-manifest toxenv.

Since the documentation page describing the TOX_SKIP_ENV has 'latest' in the URL (https://tox.wiki/en/latest/config.html#envlist), I think it should still be supported?

Environment

Provide at least:

  • OS: Ubuntu 22.10
  • pip list of the host Python where tox is installed:
$ pipx runpip tox list
Package       Version
------------- -------
cachetools    5.2.0
chardet       5.1.0
colorama      0.4.6
distlib       0.3.6
filelock      3.8.2
packaging     22.0
pip           22.3.1
platformdirs  2.6.0
pluggy        1.0.0
py            1.11.0
pyparsing     3.0.9
pyproject_api 1.2.1
setuptools    65.6.3
six           1.16.0
toml          0.10.2
tomli         2.0.1
tox           4.0.2
virtualenv    20.17.1
wheel         0.38.4
@gaborbernat gaborbernat added bug:minor does not affect many people or has no big impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. labels Dec 13, 2022
@gaborbernat gaborbernat added this to the 4.0.x milestone Dec 13, 2022
@gaborbernat
Copy link
Member

Please feel free to put in a PR for this 👍

@mgedmin
Copy link
Contributor Author

mgedmin commented Dec 14, 2022

I'm tempted to accept the challenge. Would you be able to give some hints about where I should start looking?

@mgedmin
Copy link
Contributor Author

mgedmin commented Dec 14, 2022

Would tox.session.env_select.EnvSelector.iter() be the right place to do the filtering?

mgedmin added a commit to mgedmin/tox that referenced this issue Dec 14, 2022
@mgedmin
Restore TOX_SKIP_ENV filtering
9ae5e3c 
This is still documented in docs/config.rst.  The only missing thing is
the reporting at verbosity level 2.

Fixes tox-dev#2698.
mgedmin added a commit to mgedmin/tox that referenced this issue Dec 14, 2022
@mgedmin
Restore TOX_SKIP_ENV filtering
e9bb21e 
This is still documented in docs/config.rst.  The only missing thing is
the reporting at verbosity level 2.

Fixes tox-dev#2698.
@mgedmin mgedmin mentioned this issue Dec 14, 2022
Merged
5 tasks
@mgedmin
Copy link
Contributor Author

mgedmin commented Dec 14, 2022

Well, it seems to work: #2707

gaborbernat pushed a commit to mgedmin/tox that referenced this issue Dec 15, 2022
@mgedmin @gaborbernat
Restore TOX_SKIP_ENV filtering
8a28e88 
This is still documented in docs/config.rst.  The only missing thing is
the reporting at verbosity level 2.

Fixes tox-dev#2698.
gaborbernat pushed a commit that referenced this issue Dec 15, 2022
@mgedmin
Restore TOX_SKIP_ENV filtering (#2707)
c9394e8 
Co-authored-by: Bernát Gábor <bgabor8@bloomberg.net>
Fixes #2698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:minor does not affect many people or has no big impact help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore TOX_SKIP_ENV filtering mgedmin/tox
2 participants
@mgedmin @gaborbernat