Tox 4 interprets quoted hash in commands as comment start

[nsoranzo]

Issue

Using 'foo#bar' other as part of a command seems to truncate it as soon as the first hash is encountered (i.e. 'foo).

Environment

Provide at least:

• OS: Ubuntu 20.04
• pip list of the host Python where tox is installed: irrelevant

Output of running tox

...
py: commands[0]> sed -i ''"'"'s'
/bin/sed: -e expression #1, char 1: unknown command: `''
py: exit 1 (0.00 seconds) /usr/users/ga002/soranzon/software/nsoranzo_ephemeris> sed -i ''"'"'' pid=720035
.pkg: _exit> python /usr/users/ga002/soranzon/software/nsoranzo_ephemeris/.venv/lib/python3.8/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__
  py: FAIL code 1 (1.23=setup[1.23]+cmd[0.00] seconds)
  evaluation failed :( (1.28 seconds)

Minimal example

Minimal tox.ini to reproduce:

[testenv]
allowlist_externals = sed
commands = sed -i 's#/path/to#/newpath/to#' test.txt

[jugmac00]

This is documented in https://tox.wiki/en/latest/faq.html#tox-4-changed-ini-rules

Your example would probably need to look like:

[testenv]
allowlist_externals = sed
commands = sed -i 's\#/path/to\#/newpath/to\#' test.txt

As you already know ( galaxyproject/ephemeris@f8e754f ) you can easily use a different marker/separator, e.g. |.

[nsoranzo]

Thanks for the quick reply. Search for hash in the documentation didn't help, maybe including it in the docs would make this more discoverable.

[jugmac00]

@nsoranzo Makes sense! I created #2663

[nsoranzo]

Great, thanks @jugmac00 !