Fix PYTHONPATH passed to envreport / "pip freeze" #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3flight
requested review from
gaborbernat,
asottile,
obestwalter and
jugmac00
as code owners
gaborbernat
requested changes
Nov 4, 2022
f3flight
requested review from
gaborbernat
and removed request for
obestwalter,
asottile and
jugmac00
|
@gaborbernat would you be able to have another look? |
gaborbernat
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2528
This fix uses the same approach as used for "pip install" (https://github.com/tox-dev/tox/blob/3.27.0/src/tox/venv.py#L432)