Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gethostname instead of potentially slow getfqdn #2380

Merged
merged 1 commit into from Mar 18, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 18, 2022

This avoid bug that is adding 30s on some machines where getfqdn()
is very slow, as this is caused by an unsolved python bug.

Related: https://bugs.python.org/issue35164
Fixes: #2375

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

This avoid bug that is adding 30s on some machines where getfqdn()
is very slow, as this is caused by an unsolved python bug.

Related: https://bugs.python.org/issue35164
Fixes: tox-dev#2375
@gaborbernat gaborbernat merged commit eb1bd33 into tox-dev:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox3 30s delay caused by DNSServiceCreateConnection on macos
2 participants