Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passenv: Include default env variables regardless of their case on UNIX #2378

Merged
merged 1 commit into from Mar 18, 2022

Conversation

poggenhans
Copy link

This fixes problems with environment variables that are also used in their lower-case form on UNIX systems, such as http_proxy and https_proxy. They wouldn't be passed on to the test environment, while variables such as HTTP_PROXY would.

Closes #2372

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation, breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with -- by :user:`<your username>`.
    • please, use full sentences with correct case and punctuation, for example:
      Fixed an issue with non-ascii contents in doctest text files -- by :user:`superuser`.
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

This fixes problems with environment variables
that are also used in their lower-case form,
such as http_proxy and https_proxy.
This applies only to UNIX systems since Windows is case-insensitive.

Closes tox-dev#2372
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 31dc5b1 into tox-dev:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tox passenv by default only passes HTTP_PROXY but not http_proxy
2 participants