Do not reinstall in develop mode without setup.py #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentVanlaer
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
requested changes
Nov 16, 2021
|
It seems the CI fails because python < 3.7 is not available anymore in the macos azure images, not really something I can do anything about except for just disabling these tests. |
|
Yeah, we'll need to migrate to Github Actions, this PR will need to wait for that. Also, I'll be on holiday until the 3rd of December, so unless @asottile picks it up we'll not move on this, sorry. But we've put it in the queue. |
|
I can help with GHA issue but I will still need someone to merge the fixes. |
The detection logic for figuring out whether a editable install needs to be reinstalled only works for setuptools based builds using setup.py. If setup.py cannot be found the code will fail with an invocation error. Currently no standard mechanism exists to query a package installed in editable mode whether it should be reinstalled or not. Hence, this change skips reinstallation if setup.py cannot be found. Fixes tox-dev#2197
Otherwise install_pkg will not behave correctly when is_develop=True
gaborbernat
force-pushed
the
fix-developer-mode-without-setup.py
branch
from
217bf26
to
8c4d6af
Compare
gaborbernat
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection logic for figuring out whether a editable install needs to be reinstalled only works for setuptools based builds using setup.py. If setup.py cannot be found the code will fail with an invocation error. Currently no standard mechanism exists to query a package installed in editable mode whether it should be reinstalled or not. Hence, this change skips reinstallation if setup.py cannot be found.
Fixes #2197
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc-- by :user:`<your username>`.CONTRIBUTORS(preserving alphabetical order)