Fix show config when package names are not canonical #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jul 13, 2021
| @@ -65,16 +64,15 @@ def version_info(parser): | |||
| while to_visit: | |||
| current = to_visit.pop() | |||
| current_dist = importlib_metadata.distribution(current) | |||
| current_name = canonicalize_name(current_dist.metadata["name"]) | |||
There was a problem hiding this comment.
hmmm, I was pretty sure I added the canonicalize name because there were duplicates in the output
There was a problem hiding this comment.
Yeah, not sure what happened here but canonicalize name now makes it break... do you still have your use case to validate?
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
|
I don't unfortunately :S -- I think it was within the tree of tox
dependencies but if that doesn't reproduce anymore than it's probably fine
…On Tue, Jul 13, 2021, 11:31 AM Bernát Gábor ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/tox/session/commands/show_config.py
<#2103 (comment)>:
> @@ -65,16 +64,15 @@ def version_info(parser):
while to_visit:
current = to_visit.pop()
current_dist = importlib_metadata.distribution(current)
- current_name = canonicalize_name(current_dist.metadata["name"])
Yeah, not sure what happened here but canonicalize name now makes it
break... do you still have your use case to validate?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2103 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN2BH2Q4CQCWQHYL2VDMZTTXRL6JANCNFSM5AJDYGYA>
.
|
bors bot
added a commit
to meilisearch/meilisearch-python
that referenced
this pull request
Aug 17, 2021
299: Bump tox from 3.23.1 to 3.24.1 r=alallema a=dependabot[bot] Bumps [tox](https://github.com/tox-dev/tox) from 3.23.1 to 3.24.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p> <blockquote> <h2>v3.24.1 (2021-07-31)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li><code>get_requires_for_build_sdist</code> hook (PEP 517) is assumed to return an empty list if left unimplemented by the backend build system - by :user:<code>oczkoisse</code> <code>[#2130](tox-dev/tox#2130) <https://github.com/tox-dev/tox/issues/2130></code>_</li> </ul> <p>Documentation ^^^^^^^^^^^^^</p> <ul> <li>The documentation of <code>install_command</code> now also mentions that you can provide arbitrary commands - by :user:<code>jugmac00</code> <code>[#2081](tox-dev/tox#2081) <https://github.com/tox-dev/tox/issues/2081></code>_</li> </ul> <h2>v3.24.0 (2021-07-14)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li><code>--devenv</code> no longer modifies the directory in which the <code>.tox</code> environment is provisioned - by :user:<code>isaac-ped</code> <code>[#2065](tox-dev/tox#2065) <https://github.com/tox-dev/tox/issues/2065></code>_</li> <li>Fix show config when the package names are not in canonical form - by :user:<code>gaborbernat</code>. <code>[#2103](tox-dev/tox#2103) <https://github.com/tox-dev/tox/issues/2103></code>_</li> </ul> <p>Documentation ^^^^^^^^^^^^^</p> <ul> <li>Extended environment variables section - by :user:<code>majiang</code> <code>[#2036](tox-dev/tox#2036) <https://github.com/tox-dev/tox/issues/2036></code>_</li> </ul> <p>Miscellaneous ^^^^^^^^^^^^^</p> <ul> <li><code>tox</code> no longer shows deprecation warnings for <code>distutils.sysconfig</code> on Python 3.10 - by :user:<code>9999years</code> <code>[#2100](tox-dev/tox#2100) <https://github.com/tox-dev/tox/issues/2100></code>_</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tox-dev/tox/commit/80918013ac88335331cc5c9b09f2912dad41b63a"><code>8091801</code></a> release 3.24.1</li> <li><a href="https://github.com/tox-dev/tox/commit/db5861cc7a6cb9d7479116077065423c8d358218"><code>db5861c</code></a> Alow backend build system to omit <code>get_requires_for_build_sdist</code> hook (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2131">#2131</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/a61a6b6bf8713f35e560a2449480a8ea5721bad7"><code>a61a6b6</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2119">#2119</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/62f923f1ff2d4c0260cc804fb6723a6655df7255"><code>62f923f</code></a> Update poetry link</li> <li><a href="https://github.com/tox-dev/tox/commit/20d0646554db9d503afe5b140518cbcb95c2c4de"><code>20d0646</code></a> improve documentation for <code>install_command</code> (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2111">#2111</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/b35565a2ee0bfce11e139a163ca1fde3994455ed"><code>b35565a</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2110">#2110</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/3c576a70a119fcb306b1f6e19b1faae4ee178dc4"><code>3c576a7</code></a> Fix misformed title in changelog</li> <li><a href="https://github.com/tox-dev/tox/commit/7852011425de61cf57ba2c2d06a6c8a4cc12e060"><code>7852011</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/2105">#2105</a> from tox-dev/release-3.24.0</li> <li><a href="https://github.com/tox-dev/tox/commit/c2e2e3441af72b45a03d11589908762ab0204613"><code>c2e2e34</code></a> release 3.24.0</li> <li><a href="https://github.com/tox-dev/tox/commit/91dfd3e8bdf95ca2992d675162619036345120d4"><code>91dfd3e</code></a> Add Python3.10 to CI and handle distutils deprecation</li> <li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.23.1...3.24.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After landing pypa/virtualenv#2126 I'm getting: