Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when there is no 4th arg passed to build_isolated #2056

Merged

Conversation

AntoineD
Copy link
Contributor

@AntoineD AntoineD commented May 4, 2021

This fixes a tox-conda issue with isolated build.
The command calling build_isolated.py is passed to the command conda run which seems to remove the empty arguments. Contrary to the 3rd argument, the 4th argument was not checked for existence in build_isolated.py before being used.

Thanks for contributing a pull request!

If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needed a changelog which I've added. We should also add a test, @AntoineD?

@AntoineD
Copy link
Contributor Author

AntoineD commented May 5, 2021

I don't know how to trigger this as a end user without tox-conda, would a test on build_isolated.py only be OK?

@gaborbernat
Copy link
Member

I don't know how to trigger this as a end user without tox-conda, would a test on build_isolated.py only be OK?

Yes.

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 95cec46 into tox-dev:master May 5, 2021
@gaborbernat
Copy link
Member

Releasing via #2057

@AntoineD AntoineD deleted the fix-isolated-build-4th-empty-arg branch May 5, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants