Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sigterm by killing the commands subprocess #1860

Merged
merged 2 commits into from Jan 20, 2021
Merged

Handle sigterm by killing the commands subprocess #1860

merged 2 commits into from Jan 20, 2021

Conversation

dajose
Copy link

@dajose dajose commented Jan 19, 2021

fixes #1772

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 833b33f into tox-dev:master Jan 20, 2021
@dajose dajose deleted the sigterm branch January 20, 2021 13:52
@dajose
Copy link
Author

dajose commented Jan 26, 2021

@gaborbernat when is the next release?

@gaborbernat
Copy link
Member

Don't have planned one just yet.

@dajose
Copy link
Author

dajose commented Jan 27, 2021

could you drop one for me? 🙏

@gaborbernat
Copy link
Member

#1880

@gaborbernat
Copy link
Member

https://pypi.org/project/tox/3.21.3/

ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kill tox process does not kill running commands
2 participants