Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed irrelevant Error message for invalid argument when running outside a directory with tox support files #1546 #1547

Merged
merged 3 commits into from Mar 27, 2020
Merged

Fixed irrelevant Error message for invalid argument when running outside a directory with tox support files #1546 #1547

merged 3 commits into from Mar 27, 2020

Conversation

nkpro2000sr
Copy link

@nkpro2000sr nkpro2000sr commented Mar 26, 2020 •
edited

Fixed #1546 by adding pre argument evaluation for no tox supported files.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples

@nkpro2000sr nkpro2000sr changed the title closes #1546 Fixed irrelevant Error message for invalid argument when running outside a directory with tox support files #1546 Mar 26, 2020
@gaborbernat gaborbernat merged commit f0e66bf into tox-dev:master Mar 27, 2020
@gaborbernat
Copy link
Member

Hello, this now has been released via https://pypi.org/project/tox/3.15.0/

heads up

ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
@nkpro2000sr @ssbarnea
Fixed irrelevant Error message for invalid argument when runnin… (tox…
84684a5 
…-dev#1547)

* Fixed tox-dev#1546

* Added Changelog

* Solved CI Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

@asottile asottile Awaiting requested review from asottile

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Irrelevant Error message for invalid argument when running outside a directory with tox support files
2 participants
@nkpro2000sr @gaborbernat