Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of architecture in python interpreter name #1542

Merged
merged 4 commits into from Mar 26, 2020

Conversation

bruchar1
Copy link

The wrong group was captured in the regexp, causing the arch part of the spec to include the dash.
It prevented selecting the architecture for the Python interpreted (e.g. python3.7-32).

Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, would you liked to add a changelog entry? (they're managed in the docs/changelog directory)

@gaborbernat gaborbernat merged commit 3f7eb98 into tox-dev:master Mar 26, 2020
@gaborbernat
Copy link
Member

Hello, this now has been released via https://pypi.org/project/tox/3.15.0/

heads up

ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
* Fix parsing of architecture in python interpreter name

* add myself to contributors

* added entry to changelog

* updated changelog filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants