Fix repo file links in the PR template #1363
Conversation
webknjaz
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
| @@ -5,18 +5,18 @@ much about the checklist - we will help you get started. | |||
|
|
|||
| ## Contribution checklist: | |||
|
|
|||
| (also see [CONTRIBUTING.rst](/CONTRIBUTING.rst) for details) | |||
| (also see [CONTRIBUTING.rst](../tree/master/CONTRIBUTING.rst) for details) | |||
There was a problem hiding this comment.
seems ../CONTRIBUTING.rst works as well (I just tried it by editing your PR)
There was a problem hiding this comment.
Interesting... I'm not sure how.
There was a problem hiding this comment.
https://github.com/tox-dev/tox/CONTRIBUTING.rst 404 Not Found for me.
../CONTRIBUTING.rst is relative to the current page https://github.com/tox-dev/tox/pull/1363 -> https://github.com/tox-dev/tox/pull/1363/../CONTRIBUTING.rst -> https://github.com/tox-dev/tox/CONTRIBUTING.rst
There was a problem hiding this comment.
iirc github renders the markdown in a "context" relative to where the file sits -- so it knows that down one directory is the CONTRIBUTING.rst file (./.github/../CONTRIBUTING.rst)
There was a problem hiding this comment.
Maybe you use some browser extension?
There was a problem hiding this comment.
oh what now it doesn't work, what did I do before 😕
There was a problem hiding this comment.
maybe you used some different view (like from the actual file page, not PR)? Also, there's some front-end caching here.
Links in the PR template are broken. They start with
/which effectively creates absolute URI paths relative tohttps://github.com. So/CONTRIBUTING.rstpoints tohttps://github.com/CONTRIBUTING.rst, not to the file view under this repo.Fixes #1120.
See the broken template below (as rendered when I created this PR):
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)