From 5ccf2b3e900de1b465245518599807b89b101532 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bern=C3=A1t=20G=C3=A1bor?= Date: Fri, 30 Dec 2022 16:24:40 -0800 Subject: [PATCH] PR feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Bernát Gábor --- .../package/test_python_package_util.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tests/tox_env/python/virtual_env/package/test_python_package_util.py b/tests/tox_env/python/virtual_env/package/test_python_package_util.py index 5b58430b8..5cb188128 100644 --- a/tests/tox_env/python/virtual_env/package/test_python_package_util.py +++ b/tests/tox_env/python/virtual_env/package/test_python_package_util.py @@ -51,15 +51,6 @@ def test_load_dependency_many_extra(pkg_with_extras: PathDistribution) -> None: assert str(left) == str(right) -def test_load_dependency_poetry_many_extra() -> None: - requires = [Requirement('filelock<4.0.0,>=3.9.0; extra == "extras1" or extra == "extras2"')] - result = dependencies_with_extras(requires, {"extras1"}, "") - exp = [Requirement("filelock<4.0.0,>=3.9.0")] - for left, right in zip_longest(result, exp): - assert isinstance(right, Requirement) - assert str(left) == str(right) - - def test_loads_deps_recursive_extras() -> None: requires = [ Requirement("no-extra"), @@ -72,3 +63,9 @@ def test_loads_deps_recursive_extras() -> None: ] result = dependencies_with_extras(requires, {"dev"}, "name") assert [str(i) for i in result] == ["no-extra", "dep1[magic]", "dep1", "dep2[a,b]"] + + +def test_load_dependency_requirement_or_extras() -> None: + requires = [Requirement('filelock<4.0.0,>=3.9.0; extra == "extras1" or extra == "extras2"')] + result = dependencies_with_extras(requires, {"extras1"}, "") + assert [str(r) for r in result] == ["filelock<4.0.0,>=3.9.0"]