Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in the README #155

Merged
merged 2 commits into from Feb 6, 2019
Merged

Update links in the README #155

merged 2 commits into from Feb 6, 2019

Conversation

Ophirr33
Copy link
Contributor

@Ophirr33 Ophirr33 commented Feb 2, 2019

I'm potentially interested in helping out on tower, figured a good place to start would be updating some links in the README.

Added tower-direct-service and tower-retry, removed tower-router. Looks like DirectService is going to get merged into Service eventually, but it'll be easy enough to delete the links when that happens.

Added tower-direct-service and tower-retry, removed tower-router
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 minus my one point

README.md Outdated
@@ -27,6 +27,9 @@ crates.
handle the next request, `tower-buffer` stores the request in an internal
queue ([docs][tbuf-docs]).

* [`tower-direct-service`]: Similar to the `Service` trait, but allows for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't want to add this just now since we might not be going through with this idea.

@carllerche
Copy link
Member

I removed direct-service

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 👍

@carllerche carllerche merged commit 4c5ba67 into tower-rs:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants