Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sensitive value leak #294

Merged
merged 4 commits into from Aug 31, 2022
Merged

Fix sensitive value leak #294

merged 4 commits into from Aug 31, 2022

Conversation

quininer
Copy link
Contributor

Fix #293

jplatte
jplatte approved these changes Aug 31, 2022
View reviewed changes
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let sbd. else have a look too and execute the merge.

davidpdrsn
davidpdrsn reviewed Aug 31, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Wanna add a test as well?

@quininer
Copy link
Contributor Author

@davidpdrsn I added the relevant regression tests.

davidpdrsn
davidpdrsn approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidpdrsn davidpdrsn merged commit aeb6e91 into tower-rs:master Aug 31, 2022
@quininer quininer deleted the patch-1 branch August 31, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

@jplatte jplatte jplatte approved these changes

@Nehliin Nehliin Nehliin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetSensitiveRequestHeaders layer does not mark all sensitive values
4 participants
@quininer @davidpdrsn @jplatte @Nehliin