Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for a Client #288

Open
markdingram opened this issue Aug 11, 2022 · 1 comment
Open

Add an example for a Client #288

markdingram opened this issue Aug 11, 2022 · 1 comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate T-docs Topic: documentation

Comments

@markdingram
Copy link
Contributor

markdingram commented Aug 11, 2022

Feature Request

There's some nice setup for a Client over in https://github.com/EmbarkStudios/cloud-dns . Would you be amenable to a port into this repo as an example to make this approach more discoverable?

Motivation

Trying to use a Service with TraceLayer and running into excessive generic typing, until discovering the approach in the linked repo. An example here would have saved some time.

Proposal

Alternatives

Are you happy with that approach to make it more "official" by putting in this repo?

@davidpdrsn
Copy link
Member

davidpdrsn commented Aug 11, 2022

We already have a small example client here. The main thing missing is boxing it so its easier to name the type, without having to spell out the large type. Thats probably what you ran into.

But I'm fine with adding a dedicated example as well!

markdingram added a commit to markdingram/tower-http that referenced this issue Aug 25, 2022
@davidpdrsn davidpdrsn added E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate T-docs Topic: documentation labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate T-docs Topic: documentation
Projects
None yet
Development

No branches or pull requests

2 participants