Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use doc_auto_cfg instead of doc_cfg feature for docsrs #254

Merged
merged 1 commit into from Apr 26, 2022
Merged

Use doc_auto_cfg instead of doc_cfg feature for docsrs #254

merged 1 commit into from Apr 26, 2022

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Apr 25, 2022

Motivation

Fixes #253.

Solution

Make it clear in docs that ServiceBuilderExt requires the util feature.

@jplatte jplatte requested a review from davidpdrsn April 25, 2022 17:54
@jplatte
Copy link
Collaborator Author

jplatte commented Apr 25, 2022

Before:

Screenshot_2022-04-25_195758

After:

Screenshot_2022-04-25_195807

@davidpdrsn davidpdrsn merged commit 66787bb into master Apr 26, 2022
@davidpdrsn davidpdrsn deleted the jplatte/doc-cfg branch April 26, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving to 0.3.0: no ServiceBuilderExt in the root?
2 participants
@jplatte @davidpdrsn