-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version for options in a dict #82
Conversation
First version for a dict handling the options.
Hey @RoKondo, thanks for this. To finish off, this PR needs:
|
Well nope,will do it tomorrow. With the last one I thought to still accept the old prefs. But obviously you agree to my concept of the options. |
Added warning for deprecation
Added deprecation warning
Added better merging of list to avoid duplicates.
Added the new configuration with dict WAGTAILMARKDOWN
I changed the readme also a bit by structure.. I am finished from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tiny tweaks. Elsewhere, the quoting style is inconsistent in Python code. Can we use black
from now on?
Co-authored-by: Tom Dyson <tom@torchbox.com>
Co-authored-by: Tom Dyson <tom@torchbox.com>
Thanks.. shall I change to |
Thank you both, best to install $ pip install pre-commit
# in project dir
$ pre-commit install
# run all checks once for this, then the checks will run only on the changed files
$ pre-commit run --all-files |
Thanks for the pre-commit tool - pretty cool. Hope it is fine now. |
Thank you for this PR @rokdd While doing the tidy up, I realised |
First version for a dict handling the options. No error handling if the wrong type is given. Planned a structure like: