Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update a way to mark pods as critical add-on #912

Closed
4 tasks
toshipp opened this issue May 14, 2024 · 0 comments · Fixed by #913
Closed
4 tasks

Update a way to mark pods as critical add-on #912

toshipp opened this issue May 14, 2024 · 0 comments · Fixed by #913

Comments

@toshipp
Copy link
Contributor

toshipp commented May 14, 2024

What

We use the CriticalAddonsOnly toleration to annotate pods as critical, but it had been already deprecated.
kubernetes/website#10733

We should follow this document now.
https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/

How

Remove the toleration and set the appropriate priority class.

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change a way to mark pods as critical add-on topolvm/topolvm
1 participant
@toshipp