Add lvm-path option #915
Merged
Add lvm-path option #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constants are only referred from lvm_command.go, they should be there. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
We updated the variable by two ways, use canonical way for readability. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The lvm command path is not stable on some host environments. To set it, add a new option. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
ushitora-anqou
approved these changes
May 15, 2024
peng225
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #908