Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rohlik.cz - chyba v konzoli plus spatna original price #218

Open
jakubbalada opened this issue Dec 19, 2020 · 4 comments
Open

Rohlik.cz - chyba v konzoli plus spatna original price #218

jakubbalada opened this issue Dec 19, 2020 · 4 comments
Labels
bug Something isn't working extension

Comments

@jakubbalada
Copy link
Collaborator

https://www.rohlik.cz/c300102005-citrusy?productPopup=1350163-pomeranc-odr-navelina-1-ks

Za aktualni den mame spravnou original price z API (prepoctenou na gramaz), ale spatnou z detailu produktu (za kg)
Original price:

         {
            "x":"2020-12-18T00:00:00.000Z",
            "y":null
         },
         {
            "x":"2020-12-19T00:00:00.000Z",
            "y":13.21
         },
         {
            "x":"2020-12-19T09:53:28.183Z",
            "y":44.9
         }

Navic chyba v konzoli:

Hlídačshopů.cz
content.js:17442 version: 1.8.10
12Fetch finished loading: GET "<URL>".
content.js:17288 Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at content.js:17288
    at Array.find (<anonymous>)
    at content.js:17288
    at Array.find (<anonymous>)
    at didRenderDetail2 (content.js:17288)
    at Rohlik.shouldRender (content.js:17300)
    at MutationObserver.observe.childList (content.js:16681)
@rarous
Copy link
Collaborator

rarous commented Dec 19, 2020

Ad Chyba v konzoli: ta je z rohlíku, nesouvisí s námi, jen díky asynchronní povaze, se jejich hlášky strkají do naší "sekce". Je to matoucí a asi to zase zruším.

@rarous
Copy link
Collaborator

rarous commented Dec 19, 2020

@jakubbalada co navrhuješ, jak se s tím poprat? :)

@jakubbalada
Copy link
Collaborator Author

Vypada to, ze na strankovani taky neni original price na kus, takze to nejspis prepocitavame v KBC. Pak bysme to meli sjednotit a stejne pocitat i na detailu. Idealne na jednom miste - poslat cenu z extension, prepocitat, pridat do datasetu a poslat zpatky.

@rarous
Copy link
Collaborator

rarous commented Jul 12, 2022

Rohlik přemázne graf na přímém detailu produktu. Musíme tam přidat čekání na stabilizaci DOM.

@rarous rarous added bug Something isn't working and removed enhancement New feature or request labels Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extension
Projects
None yet
Development

No branches or pull requests

2 participants