Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skip CI] Specify what project to add the NuGet #71

Merged
merged 2 commits into from
May 1, 2018

Conversation

nopara73
Copy link
Contributor

@nopara73 nopara73 commented May 1, 2018

As someone who never used code coverage it was not clear to me until I've read it in this post: https://medium.com/@tonerdo/setting-up-coveralls-with-coverlet-for-a-net-core-project-2c8ec6c5dc58

As someone who never used code coverage it was not clear to me until I've read it in this post: https://medium.com/@tonerdo/setting-up-coveralls-with-coverlet-for-a-net-core-project-2c8ec6c5dc58
@nopara73 nopara73 changed the title Specify what project to add the NuGet [Skip CISpecify what project to add the NuGet May 1, 2018
@nopara73 nopara73 changed the title [Skip CISpecify what project to add the NuGet [Skip CI] Specify what project to add the NuGet May 1, 2018
Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just 1 comment

README.md Outdated
@@ -37,7 +37,7 @@ _Note: The assembly you'd like to get coverage for must be different from the as

## Usage

Coverlet doesn't require any additional setup other than including the NuGet package. It integrates with the `dotnet test` infrastructure built into the .NET Core CLI and when enabled, will automatically generate coverage results after tests are run.
Coverlet doesn't require any additional setup other than including the NuGet package to the unit test project. It integrates with the `dotnet test` infrastructure built into the .NET Core CLI and when enabled, will automatically generate coverage results after tests are run.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the unit test project to in the unit test project

@nopara73
Copy link
Contributor Author

nopara73 commented May 1, 2018

*Sorry for kicking off the CI.

@tonerdo tonerdo merged commit 5ede288 into coverlet-coverage:master May 1, 2018
@nopara73 nopara73 deleted the patch-1 branch May 1, 2018 14:04
NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
[Skip CI] Specify what project to add the NuGet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants