Adds retry functionality to copy back the original assembly. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's an interesting result from AppVeyor for the debug build. :-) How does that work? Is it using the older version, or is it dog-fooding off the new code? |
Pull Request Test Coverage Report for Build #53
💛 - Coveralls |
|
Thanks for this! Can you please do the same on this line https://github.com/finbourne/coverlet/blob/590cbc3bba8f1655960da349f0596539f121653d/src/coverlet.core/Coverage.cs#L133. That's the cause of the Windows CI failure |
|
uno momento |
tonerdo
requested changes
Apr 9, 2018
src/coverlet.core/Coverage.cs
Outdated
| currentSleep *= 2; | ||
| return sleep; | ||
| }; | ||
| RetryHelper.Retry(() => InstrumentationHelper.RestoreOriginalModule(result.ModulePath, _identifier), retryStrategy, 10); |
There was a problem hiding this comment.
Let's move all this logic into InstrumentationHelper.RestoreOriginalModule. You can put the code in that function into the Retry(() => {} delegate
src/coverlet.core/Coverage.cs
Outdated
| currentSleep *= 2; | ||
| return sleep; | ||
| }; | ||
| RetryHelper.Retry(() => File.Delete(result.HitsFilePath), retryStrategy, 10); |
There was a problem hiding this comment.
Same thing here. Create an InstrumentationHelper.DeleteHitsFile and basically move this block into that
NorekZ
pushed a commit
to NorekZ/coverlet
that referenced
this pull request
Nov 8, 2018
Adds retry functionality to copy back the original assembly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25
I've run this locally, and it seems fine. Would be handy to have someone else verify that.