Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when using multiple referenced libraries. #14

Merged
merged 2 commits into from Mar 24, 2018
Merged

Fix errors when using multiple referenced libraries. #14

merged 2 commits into from Mar 24, 2018

Conversation

wlmiller
Copy link
Contributor

Addresses #8.

There's still a separate issue where referenced libraries with 0 coverage will cause errors because no HitsFile is generated for them. Adding the check in Coverage.CalculateCoverage would be one way to handle that case.

@coveralls
Copy link

Pull Request Test Coverage Report for Build #22

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 82.967%

Files with Coverage Reduction New Missed Lines %
/src/coverlet.core/CoverageTracker.cs 1 66.67%
Totals Coverage Status
Change from base Build #20: -0.2%
Covered Lines: 302
Relevant Lines: 364

💛 - Coveralls

@tonerdo
Copy link
Collaborator

tonerdo commented Mar 24, 2018

0 coverage will cause errors because no HitsFile

This is a very compelling point. Once the tests pass, I'll merge this in and accept the other guy's PR and do some personal verifications. I figure as long as the final summary explicitly states 0% as opposed to just failing silently, we should be in a good place

@tonerdo tonerdo merged commit f442e6a into coverlet-coverage:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants