Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda View - Event Customization/Slot #189

Open
jilliandburke opened this issue Jul 2, 2023 · 3 comments
Open

Agenda View - Event Customization/Slot #189

jilliandburke opened this issue Jul 2, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@jilliandburke
Copy link

Is your feature request related to a problem? Please describe.
Hello, I'm back again 馃槄

I've been loving the new additions and the dark mode looks wonderful!

For this new idea I'm bringing forward it's very possible that I've missed a way to do this in the documentation somewhere (or that this is a bug), but the problem I've noticed is that when going down to the mobile agenda view in month mode and clicking on a day, my events don't use the custom month event view that I've created using the monthEvent slot. They're back to the default configuration as seen in Additional Context below.

Describe the solution you'd like
What would be most convenient in my use-case would just be having the agenda view respect the monthEvent slot I'm already using. However, there could be an argument for having an agenda view slot specifically, though I would imagine that's considerably more work, especially if no one is explicitly requesting it at this time.

If this is something attainable for a new contributor to Qalendar then I'd be happy to try my hand at it!

Additional context

Desktop month events
image

Mobile month events
image

@tomosterlund
Copy link
Owner

Hi @jilliandburke

Thanks for your appreciation. Actually this was one of of the breaking changes for v3, but is definitely an important feature also for the agenda view.

I think this feature is excellent if you want to have a shot at it yourself: you would get to dive down from the top level component Qalendar.vue, all the way down to AgendaEventTile.vue where the slot should be implemented. Also shouldn't be too tricky, you could just copy paste the implementation of monthEvent but with different naming. I would also add a test for this, in cypress/e2e/06-customized-events.cy.ts

Also I think the latter of the options you mention, an agendaEvent slot, is the better option here. I wouldn't be surprised if, at some point, a feature request is opened for an agenda view on all screen sizes.

@tomosterlund tomosterlund added the enhancement New feature or request label Jul 6, 2023
@jilliandburke
Copy link
Author

@tomosterlund sounds great, I'll give it a shot!

@robairhome
Copy link

robairhome commented Dec 9, 2023

Hey, thanks for maintaining this fantastic library Tom, I love how thoughtfully designed it is.

I needed the custom agendaEvent too, I hope you don't mind but I've submitted a PR with the changes. This is really annoying, but I only have a windows machine so I wasn't able to run the e2e tests with cypress so I had to manually test the changes. I've written the cypress tests and included them in the PR, but as I've not been able to run them I want to let you know that they probably need to be double checked.

Sorry about that.

We are an unfunded two person startup so don't have much money to sponsor this as I would like- but I've bought you a coffee as a small token of gratitude. If what we are working on ever takes off I'll sponsor this library more regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants