Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional options for Event Flyout #165

Open
hugoaboud opened this issue May 7, 2023 · 2 comments
Open

Additional options for Event Flyout #165

hugoaboud opened this issue May 7, 2023 · 2 comments

Comments

@hugoaboud
Copy link

I've been very happy with this lib so far, but I needed a little more flexibility on the event flyout, so I've implemented them on the flyout-options branch of my fork:
https://github.com/hugoaboud/qalendar/tree/flyout-options

I've added 2 options and 1 feature:

  • eventDialog.absolutePosition: If true, the dialog is positioned within the calendar week, so it's always next to the event that opened it and not "floating".
  • eventDialog.disableCloseOnClickOutside: If true, clicking outside the dialog won't close it.
  • qalendar.closeFlyout(): Exposed a method on the ref to close the flyout externally.

The first one is a UX preference of the current project I'm working on.
The second and third allows the application to take full control of the event dialog, when using isCustom (I haven't found an easy way to close the dialog from a custom close button, please let me know).

Please let me know if it's interesting for the main project, and what changes might be necessary.

@tomosterlund
Copy link
Owner

tomosterlund commented May 8, 2023

Hi @hugoaboud. Thank you very much for opening this issue.

  • eventDialog.disableCloseOnClickOutside I like this idea. If you want to open a pull request for this one, we could definitely make this happen 👍

  • eventDialog.absolutePosition I'm not sure I see the value of this one yet. Maybe you can help me understand it better; to me it just appears as if the positioning looks the same as before, but now it's glued closer to the event itself. If the positioning looks off, I'd rather be open to working on the default positioning of the dialog, than adding an option for an almost identical outcome. Did you encounter some annoying behavior that made you want this option? If so, could you share a screenshot please?

  • qalendar.closeFlyout() exists, it's documented as props.closeEventDialog in the documentation.

@hugoaboud
Copy link
Author

I'm building a small application which uses mostly the week view for scheduling, and sometimes it feels unnatural to have the dialog floating over the other events when I'm trying to read them and time slots that I might want to click.

However, the solution on this branch is not working on the project with a custom dialog, and I don't have much time to work on a better version of it to demonstrate, so I guess I won't push this forward for now.

About the closeFlyout I'm sorry, completely missed that one!

I'll replicate the disableCloseOnClickOutside on a new branch and open a PR for it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants