Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ignoring Go built-in functions when excluding functions #29

Merged
merged 1 commit into from Nov 8, 2021
Merged

Support ignoring Go built-in functions when excluding functions #29

merged 1 commit into from Nov 8, 2021

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 1, 2021

The Go AST identifies built-in functions as an ast.Ident instead of an ast.SelectorExpr. Add a case to ignore them when checking for ignored functions.

Closes #28

@tommy-muehle tommy-muehle merged commit f391143 into tommy-muehle:master Nov 8, 2021
@tommy-muehle
Copy link
Owner

@gdavison Thank you very much for the contribution!

@butuzov butuzov mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommy-muehle tommy-muehle tommy-muehle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go built-in functions are not recognized when excluding functions
2 participants
@gdavison @tommy-muehle