Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<inner type> for Item #717

Open
pickx opened this issue Apr 23, 2024 · 0 comments
Open

Implement From<inner type> for Item #717

pickx opened this issue Apr 23, 2024 · 0 comments
Labels
A-edit Area: TOML editing API C-enhancement Category: Raise on the bar on expectations

Comments

@pickx
Copy link

pickx commented Apr 23, 2024

one thing I found surprising while working with toml_edit after using toml, is that Item doesn't implement From<{Value,Table,ArrayOfTables}>, in contrast with toml::Value which does have equivalent From implementations. this makes code that manually builds a document a little more verbose.

and maybe there are more things in toml_edit which could benefit from a From implementation, like toml_edit::Value or Formatted.

@epage epage added C-enhancement Category: Raise on the bar on expectations A-edit Area: TOML editing API labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edit Area: TOML editing API C-enhancement Category: Raise on the bar on expectations
Projects
None yet
Development

No branches or pull requests

2 participants