dev: refactor regexp usage

[butuzov]

This PR intends to bring the next features/fixes to wrapcheck:

1. avoid compiling regexp rules into regexp.Regexp for checking each error returning function.
2. removing os.Exit(1) in case fail to compile regexp rule from the codebase ( we can't handle such cases in golangci-lint: output is hidden, so no log messages received, which ends in no issues or errors comes from wrapcheck if bad regexp provided).

P.S. The rest of the coding is changed by gofumpt automatically.
P.P.S. It would be also great to release fix changes asap (so we update golangci-lint).

[tomarrell]

I would also ask that you include test cases testing for the functionality that has changed in order to confirm that the issue is resolved.

[butuzov]

I would also ask that you include test cases testing for the functionality that has changed in order to confirm that the issue is resolved.

let me think about this, analysistest isn't designed to test linter errors.

[butuzov]

@tomarrell I have added a test case and changed the way it passes compiled regexes around. Can you check if this solution suites you?

[butuzov]

ping @tomarrell, do my explanations and fixes make sense?

[tomarrell]

Thanks for the ping @butuzov, I'll take a look and let you know.

[tomarrell]

@butuzov Did you maybe forget to check in the .wrapcheck.yaml file used as testdata?

[butuzov]

you are right! I forgot to commit it! now its fixed.

[tomarrell]

Thanks for that. There's a couple of things I would like to check locally, however I've just started a vacation, but plan to finish this review in the next day or two.

I appreciate your patience in the meantime.

[butuzov]

No problem. This can wait.

[tomarrell]

Looks good. Just made some minor changes, added a more generic way to skip the analysistest run so they can be tested manually.

Thanks for the contribution!

[butuzov]

thank you!