From 25adef7ae898acbb6da78899f84ce8accfdf63f7 Mon Sep 17 00:00:00 2001 From: Kartavya Vashishtha Date: Tue, 9 Aug 2022 13:41:46 +0530 Subject: [PATCH 1/2] add must_use for CollectorBuilder::finish --- tracing-subscriber/src/fmt/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/tracing-subscriber/src/fmt/mod.rs b/tracing-subscriber/src/fmt/mod.rs index f34ff691cd..fe935745e2 100644 --- a/tracing-subscriber/src/fmt/mod.rs +++ b/tracing-subscriber/src/fmt/mod.rs @@ -476,6 +476,7 @@ where subscribe::Subscribe + Send + Sync + 'static, { /// Finish the builder, returning a new `FmtCollector`. + #[must_use = "You may want to use `try_init` or similar to actually install the collector."] pub fn finish(self) -> Collector { let collector = self.inner.with_collector(Registry::default()); Collector { From 5c32bf5a415c812eef40fd2dac149ab740f26f6f Mon Sep 17 00:00:00 2001 From: Eliza Weisman Date: Wed, 10 Aug 2022 16:41:25 -0700 Subject: [PATCH 2/2] Update tracing-subscriber/src/fmt/mod.rs --- tracing-subscriber/src/fmt/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tracing-subscriber/src/fmt/mod.rs b/tracing-subscriber/src/fmt/mod.rs index fe935745e2..2230362d0e 100644 --- a/tracing-subscriber/src/fmt/mod.rs +++ b/tracing-subscriber/src/fmt/mod.rs @@ -476,7 +476,7 @@ where subscribe::Subscribe + Send + Sync + 'static, { /// Finish the builder, returning a new `FmtCollector`. - #[must_use = "You may want to use `try_init` or similar to actually install the collector."] + #[must_use = "you may want to use `try_init` or similar to actually install the collector."] pub fn finish(self) -> Collector { let collector = self.inner.with_collector(Registry::default()); Collector {