Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: tracing field names CAN actually have a dot in them now #2895

Open
adamchalmers opened this issue Feb 29, 2024 · 0 comments · May be fixed by #2908
Open

Docs: tracing field names CAN actually have a dot in them now #2895

adamchalmers opened this issue Feb 29, 2024 · 0 comments · May be fixed by #2908

Comments

@adamchalmers
Copy link
Contributor

Docs for #[instrument] claim that "The name of the field must be a single valid Rust identifier, nested (dotted) field names are not supported."

But then later they use an example field name which does have a dot:

#[instrument(fields(http.uri = req.uri(), http.method = req.method()))]

So the docs are outdated, and fields are no longer restricted to being a single Rust identifier.

@mladedav mladedav linked a pull request Mar 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant