Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-opentelemetry 0.18.0 missing commits? #2501

Closed
punkeel opened this issue Mar 11, 2023 · 2 comments
Closed

tracing-opentelemetry 0.18.0 missing commits? #2501

punkeel opened this issue Mar 11, 2023 · 2 comments

Comments

@punkeel
Copy link

punkeel commented Mar 11, 2023

Bug Report

I am confused by tracing-opentelemetry=0.18.0. According to docs.rs, a4f2ee2 is the commit for 0.18.0. It was merged on 2022-09-19 (see PR #2312).

It seems like there are many commits missing from that version. This can be observed locally with git log --oneline a4f2ee2a12f3269dd19e9461d48fe2e6d32beba6..@ ., or using GitHub's comparison page.

For example, PR #1226 was merged in 2021, but isn't in 0.18.0. This one is particularly visible, as it renames layer.rs to subscriber.rs. The GitHub history page for subscriber.rs is clear on that:

Renamed from tracing-opentelemetry/src/layer.rs

Happened in 2021, and is the only rename for this file.

I guess I'm doing some git-fu wrong, but what? 🤕

Version

tracing-opentelemetry 0.18.0

Crates

tracing-opentelemetry

@punkeel
Copy link
Author

punkeel commented Mar 11, 2023

The tagged commit for tracing-opentelemetry-0.18.0 is a4f2ee2, so this would explain how it got published.

Comparing commit histories:

image

vs

image

cc @hawkw, if you know, was this done deliberately? I'm not sure how releases are done for the tracing crates.

@punkeel
Copy link
Author

punkeel commented Mar 11, 2023

Mystery solved! :-)

From the readme:

The master branch is the pre-release, development version of tracing. Please see the v0.1.x branch for the versions of tracing released to crates.io.

@punkeel punkeel closed this as completed Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant