opentelemetry: on_event respects event's explicit parent #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtescher
added
the
crate/opentelemetry
jtescher
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Good fix, on_event should respect explicit event parents. Thanks @wprzytula
hawkw
approved these changes
Sep 2, 2022
hawkw
changed the title
hawkw
requested changes
Sep 2, 2022
There was a problem hiding this comment.
@wprzytula would you mind changing this branch to target master rather than v0.1.x, so that the fix can land on the tracing 0.2 development branch? Maintainers will then handle backporting this change to v0.1.x and publishing a new tracing-opentelemetry version from that branch.
Thank you!
wprzytula
requested review from
yaahc,
carllerche and
davidbarsky
as code owners
One can want to have an event added from outside context of a span, especially in an async code (e.g. between polls of the future, or between polling multiple futures instrumented with that span). Then it is expected that the event will be attached indeed to the span specified as the parent and not the contextual one.
wprzytula
force-pushed
the
respect-event-parent
branch
2 times, most recently
from
c64afe5
to
248ee2d
Compare
wprzytula
requested review from
hawkw
and removed request for
carllerche,
yaahc and
davidbarsky
|
@hawkw I followed your suggestions and the PR is ready. |
|
Any estimations when this fix gets backported to |
We typically do it whenever we do a release; I'm doing some backports right now and will ping you when it's ready. |
davidbarsky
pushed a commit
that referenced
this pull request
Sep 8, 2022
…#2296) One can want to have an event added from outside context of a span, especially in an async code (e.g. between polls of the future, or between polling multiple futures instrumented with that span). Then it is expected that the event will be attached indeed to the span specified as the parent and not the contextual one. Fixes: #2295 See #2295
hawkw
pushed a commit
that referenced
this pull request
Sep 19, 2022
…#2296) One can want to have an event added from outside context of a span, especially in an async code (e.g. between polls of the future, or between polling multiple futures instrumented with that span). Then it is expected that the event will be attached indeed to the span specified as the parent and not the contextual one. Fixes: #2295 See #2295
hawkw
pushed a commit
that referenced
this pull request
Sep 19, 2022
…#2296) One can want to have an event added from outside context of a span, especially in an async code (e.g. between polls of the future, or between polling multiple futures instrumented with that span). Then it is expected that the event will be attached indeed to the span specified as the parent and not the contextual one. Fixes: #2295 See #2295
hawkw
pushed a commit
that referenced
this pull request
Sep 19, 2022
### Breaking Changes - Upgrade to `v0.18.0` of `opentelemetry` (#2303) For list of breaking changes in OpenTelemetry, see the [v0.18.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry/CHANGELOG.md#v0180). ### Fixed - `on_event` respects event's explicit parent (#2296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can want to have an event added from outside context of a span,
especially in an async code (e.g. between polls of the future, or
between polling multiple futures instrumented with that span). Then it
is expected that the event will be attached indeed to the span specified
as the parent and not the contextual one.
Fixes: #2295
Motivation
see #2295
Solution
see #2295