Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FieldSet implement AsSerde #2241

Merged
merged 3 commits into from Jul 26, 2022
Merged

Make FieldSet implement AsSerde #2241

merged 3 commits into from Jul 26, 2022

Conversation

iliakonnov
Copy link
Contributor

Motivation

I've wanted to serialize fieldset of current span.

Solution

Expose already existing SerializeFieldSet for users by implementing AsSerde for FieldSet.

@iliakonnov iliakonnov requested review from hawkw, davidbarsky and a team as code owners July 23, 2022 16:28
@bryangarza bryangarza self-requested a review July 25, 2022 20:11
hawkw
hawkw approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me, thank you!

@bryangarza bryangarza removed their request for review July 25, 2022 20:25
@hawkw hawkw enabled auto-merge (squash) July 26, 2022 22:52
@hawkw hawkw merged commit 497f668 into tokio-rs:master Jul 26, 2022
hawkw pushed a commit that referenced this pull request Jul 29, 2022
@iliakonnov @hawkw
serde: implement AsSerde for FieldSet (#2241)
1dbd668 
## Motivation

I've wanted to serialize fieldset of current span.

## Solution

Expose already existing `SerializeFieldSet` for users by implementing `AsSerde` for `FieldSet`.
@hawkw hawkw mentioned this pull request Jul 29, 2022
Merged
hawkw pushed a commit that referenced this pull request Jul 29, 2022
@iliakonnov @hawkw
serde: implement AsSerde for FieldSet (#2241)
f1db358 
## Motivation

I've wanted to serialize fieldset of current span.

## Solution

Expose already existing `SerializeFieldSet` for users by implementing `AsSerde` for `FieldSet`.
hawkw pushed a commit that referenced this pull request Jul 29, 2022
@iliakonnov @hawkw
serde: implement AsSerde for FieldSet (#2241)
27ffce2 
## Motivation

I've wanted to serialize fieldset of current span.

## Solution

Expose already existing `SerializeFieldSet` for users by implementing `AsSerde` for `FieldSet`.
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iliakonnov @hawkw @bryangarza