chore(ci): test workflow embetterments #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
davidbarsky
approved these changes
Jun 23, 2022
.github/workflows/test.yml
Outdated
| toolchain: ${{ matrix.rust }} | ||
| profile: minimal | ||
| override: true | ||
| - name: install cargo-nextest |
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
this broke when running the tests with `--all-features`, because...we weren't previously doing that. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
(the annotations are not great) Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
`--all-features` enables the `max_level_XXX` features on `tracing`, and this breaks a bunch of tests... Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Jun 23, 2022
This branch makes the following changes to the CI test workflows: - Consolidate all tests into a single workflow again. We had previously broken things out to allow restarting only some failed checks, but now GitHub Actions allows restarting individual jobs, which is much nicer, and we can combine everything into one workflow. - Gate starting any tests/checks on an initial `cargo check` run. This should mean that if code doesn't compile, we don't spin up a huge number of test jobs that all end up failing, and delaying other PRs' CI runs. - Use `cargo nextest` for running tests. This should make test runs a bit quicker, and also get us other nice features like retries for flaky tests. - Switch to `taiki-e/install-action` for installing stuff like `cargo-hack`, `nextest`, and `wasm-pack`. This is a bit nicer than just `curl`ing stuff. - Use a matrix for testing across toolchains/OSes, instead of having separate jobs. This reduces the complexity of the CI workflow a bit. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution