core: remove vendored lazy_static
on no-std
#2173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
no_std
targets use a vendored version oflazy_static
thatuses the
spin
crate'sOnce
type, while thestd
target uses theonce_cell
crate'sLazy
type. This is unfortunate, as thelazy_static
macro has a different interface from theLazy
cell type.This increases the amount of code that differs based on whether or not
std
is enabled.Solution
This branch removes the vendored
lazy_static
macro and replaces itwith a reimplementation of
once_cell::sync::Lazy
that usesspin::Once
rather thanonce_cell::sync::OnceCell
as the inner "oncetype". Now, all code can be written against a
Lazy
struct with thesame interface, regardless of whether or not
std
is enabled.Note that this change is only against
v0.1.x
, since the vendoredlazy_static!
macro has already been removed onmaster
.