Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from lazy_static to once_cell #2147

Merged
merged 2 commits into from Jun 6, 2022
Merged

Migrate from lazy_static to once_cell #2147

merged 2 commits into from Jun 6, 2022

Conversation

james7132
Copy link
Contributor

Replace lazy_static with once_cell. Fixes #2146.

Motivation

lazy_static!, while a declarative macro, is a macro nonetheless. It can add quite a bit of additional compilation time cost. once_cell::sync::Lazy does the same thing with generics, and can be used more flexibly (i.e. non-static lazily initialized values), and has been proposed to be added to std (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of a dependent project: bevy, which is using tracing. lazy_static and once_cell are both in our dependency tree and both end up doing the same thing.

Solution

Migrate to once_cell.

hawkw
hawkw approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems fine to me. I have a very minor preference for making the tracing-core and tracing-subscriber changes in separate branches, but I'm not going to block merging this based on that.

@hawkw hawkw enabled auto-merge (squash) June 6, 2022 17:18
hawkw
hawkw reviewed Jun 6, 2022
View reviewed changes
tracing-flame/src/lib.rs Outdated Show resolved Hide resolved
@hawkw hawkw merged commit 10da627 into tokio-rs:master Jun 6, 2022
hawkw pushed a commit that referenced this pull request Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
45a1cea 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
@hawkw hawkw mentioned this pull request Jun 6, 2022
Merged
hawkw pushed a commit that referenced this pull request Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
ef4991b 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this pull request Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
7591fa1 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this pull request Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
bd014f0 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this pull request Jun 7, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
29b265d 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw added a commit that referenced this pull request Jun 7, 2022
@hawkw
core: prepare to release v0.1.27
18fe1c1 
# 0.1.27 (June 7, 2022)

This release of `tracing-core` introduces a new `DefaultCallsite` type,
which can be used by instrumentation crates rather than implementing
their own callsite types. Using `DefaultCallsite` may offer reduced
overhead from callsite registration.

### Added

- `DefaultCallsite`, a pre-written `Callsite` implementation for use in
  instrumentation crates ([#2083])
- `ValueSet::len` and `Record::len` methods returning the number of
  fields in a `ValueSet` or `Record` ([#2152])

### Changed

- Replaced `lazy_static` dependency with `once_cell` ([#2147])

### Documented

- Added documentation to the `callsite` module ([#2088], [#2149])

Thanks to new contributors @jamesmunns and @james7132 for contributing
to this release!

[#2083]: #2083
[#2152]: #2152
[#2147]: #2147
[#2088]: #2088
[#2149]: #2149
@hawkw hawkw mentioned this pull request Jun 7, 2022
Merged
hawkw added a commit that referenced this pull request Jun 7, 2022
@hawkw
core: prepare to release v0.1.27 (#2155)
d6699fe 
# 0.1.27 (June 7, 2022)

This release of `tracing-core` introduces a new `DefaultCallsite` type,
which can be used by instrumentation crates rather than implementing
their own callsite types. Using `DefaultCallsite` may offer reduced
overhead from callsite registration.

### Added

- `DefaultCallsite`, a pre-written `Callsite` implementation for use in
  instrumentation crates ([#2083])
- `ValueSet::len` and `Record::len` methods returning the number of
  fields in a `ValueSet` or `Record` ([#2152])

### Changed

- Replaced `lazy_static` dependency with `once_cell` ([#2147])

### Documented

- Added documentation to the `callsite` module ([#2088], [#2149])

Thanks to new contributors @jamesmunns and @james7132 for contributing
to this release!

[#2083]: #2083
[#2152]: #2152
[#2147]: #2147
[#2088]: #2088
[#2149]: #2149
hawkw added a commit that referenced this pull request Jun 29, 2022
@hawkw
subscriber: prepare to release v0.3.12
67c7a4c 
# 0.3.12 (Jun 29, 2022)

This release of `tracing-subscriber` adds a new `Layer::event_enabled`
method, which allows `Layer`s to filter events *after* their field
values are recorded; a `Filter` implementation for `reload::Layer`, to
make using `reload` with per-layer filtering more ergonomic, and
additional inherent method downcasting APIs for the `Layered` type. In
addition, it includes dependency updates, and minor fixes for
documentation and feature flagging.

### Added

- **layer**: `Layer::event_enabled` method, which can be implemented to
  filter events based on their field values (#2008)
- **reload**: `Filter` implementation for `reload::Layer` (#2159)
- **layer**: `Layered::downcast_ref` and `Layered::is` inherent methods
  (#2160)

### Changed

- **parking_lot**: Updated dependency on `parking_lot` to 0.13.0
  (#2143)
- Replaced `lazy_static` dependency with `once_cell` (#2147)

### Fixed

- Don't enable `tracing-core` features by default (#2107)
- Several documentation link and typo fixes (#2064, #2068, #2077,
  #2161, #1088)

Thanks to @ben0x539, @jamesmunns, @georgemp, @james7132, @jswrenn,
@CAD97, and @guswynn for contributing to this release!
@hawkw hawkw mentioned this pull request Jun 29, 2022
Merged
hawkw added a commit that referenced this pull request Jun 29, 2022
@hawkw
subscriber: prepare to release v0.3.12 (#2187)
d86d2a4 
# 0.3.12 (Jun 29, 2022)

This release of `tracing-subscriber` adds a new `Layer::event_enabled`
method, which allows `Layer`s to filter events *after* their field
values are recorded; a `Filter` implementation for `reload::Layer`, to
make using `reload` with per-layer filtering more ergonomic, and
additional inherent method downcasting APIs for the `Layered` type. In
addition, it includes dependency updates, and minor fixes for
documentation and feature flagging.

### Added

- **layer**: `Layer::event_enabled` method, which can be implemented to
  filter events based on their field values (#2008)
- **reload**: `Filter` implementation for `reload::Layer` (#2159)
- **layer**: `Layered::downcast_ref` and `Layered::is` inherent methods
  (#2160)

### Changed

- **parking_lot**: Updated dependency on `parking_lot` to 0.13.0
  (#2143)
- Replaced `lazy_static` dependency with `once_cell` (#2147)

### Fixed

- Don't enable `tracing-core` features by default (#2107)
- Several documentation link and typo fixes (#2064, #2068, #2077,
  #2161, #1088)

Thanks to @ben0x539, @jamesmunns, @georgemp, @james7132, @jswrenn,
@CAD97, and @guswynn for contributing to this release!
@jaudiger jaudiger mentioned this pull request Jul 26, 2022
Open
@Turbo87
Copy link
Contributor

Turbo87 commented Aug 3, 2022

maybe I'm misunderstanding the release process of this package, but is there a reason that tracing-log#0.2.0, which includes this change, has not been released yet? 🤔

@lopopolo lopopolo mentioned this pull request Sep 2, 2022
Closed
@jplatte jplatte mentioned this pull request Jun 29, 2023
Closed
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@yaahc yaahc Awaiting requested review from yaahc yaahc is a code owner

@carllerche carllerche Awaiting requested review from carllerche carllerche is a code owner

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from lazy_static to once_cell
3 participants
@james7132 @Turbo87 @hawkw