tracing: fix issues compiling for WASM/other <=32-bit platforms #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the "unregistered" interest state from `0xDEADFACED` to`0xDEAD`, which should fit in a `usize` even on 16-bit platforms. The actual value of this thing doesn't matter at all, it just has to be "not 0, 1, or 2", and it's good for it to be something weird to make it more obvious in the event of stuff going wrong. This should fix a warning being emitted when building for wasm (and other <=32-bit platforms) because the previous literal would be truncated.
Apparently the wasm-bindgen test messes with these somehow, so just skip them.
hawkw
changed the title
davidbarsky
approved these changes
Apr 8, 2022
|
Clippy failure is expected, #2059 will fix that, but this one has to merge first as it fixes tests. |
hawkw
added a commit
that referenced
this pull request
Apr 9, 2022
This changes the "unregistered" interest state from `0xDEADFACED` to`0xDEAD`, which should fit in a `usize` even on 16-bit platforms. The actual value of this thing doesn't matter at all, it just has to be "not 0, 1, or 2", and it's good for it to be something weird to make it more obvious in the event of stuff going wrong. This should fix a warning being emitted when building for wasm (and other <=32-bit platforms) because the previous literal would be truncated. Also, the `wasm_bindgen_test` macro apparently messes with the `macros_redefined_core` tests, so skip them on wasm.
hawkw
added a commit
that referenced
this pull request
Apr 9, 2022
# 0.1.33 (April 9, 2022) This release adds new `span_enabled!` and `event_enabled!` variants of the `enabled!` macro, for testing whether a subscriber would specifically enable a span or an event. ### Added - `span_enabled!` and `event_enabled!` macros ([#1900]) - Several documentation improvements ([#2010], [#2012]) ### Fixed - Compilation warning when compiling for <=32-bit targets (including `wasm32`) ([#2060]) Thanks to @guswynn, @arifd, @hrxi, @CAD97, and @name1e5s for contributing to this release! [#1900]: #1900 [#2010]: #2010 [#2012]: #2012 [#2060]: #2060
hawkw
added a commit
that referenced
this pull request
Apr 9, 2022
# 0.1.33 (April 9, 2022) This release adds new `span_enabled!` and `event_enabled!` variants of the `enabled!` macro, for testing whether a subscriber would specifically enable a span or an event. ### Added - `span_enabled!` and `event_enabled!` macros ([#1900]) - Several documentation improvements ([#2010], [#2012]) ### Fixed - Compilation warning when compiling for <=32-bit targets (including `wasm32`) ([#2060]) Thanks to @guswynn, @arifd, @hrxi, @CAD97, and @name1e5s for contributing to this release! [#1900]: #1900 [#2010]: #2010 [#2012]: #2012 [#2060]: #2060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the "unregistered" interest state from
0xDEADFACEDto
0xDEAD, which should fit in ausizeeven on 16-bit platforms. Theactual value of this thing doesn't matter at all, it just has to be "not
0, 1, or 2", and it's good for it to be something weird to make it more
obvious in the event of stuff going wrong.
This should fix a warning being emitted when building for wasm (and
other <=32-bit platforms) because the previous literal would be
truncated.
Also, the
wasm_bindgen_testmacro apparently messes with themacros_redefined_coretests, so skip them on wasm.