tracing: Fix wrong log level in warn macro #1929 #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaasg
requested review from
hawkw,
davidbarsky and
a team
as code owners
hawkw
pushed a commit
that referenced
this pull request
Feb 17, 2022
## Motivation I was scrolling through the code in `tracing/src/macros.rs` and noticed a possibly wrong log level in the `warn!` macro: https://github.com/tokio-rs/tracing/blob/4e65750b13721fee7a7ac05b053e1b9c3d21244f/tracing/src/macros.rs#L1698 ## Solution This branch changes the level to `Level::WARN` in the incorrect macro arm. Fixes: #1929 Co-authored-by: Nicolaas Geldenhuys <nicolaas.geldenhuys@cartrack.com>
hawkw
pushed a commit
that referenced
this pull request
Feb 17, 2022
## Motivation I was scrolling through the code in `tracing/src/macros.rs` and noticed a possibly wrong log level in the `warn!` macro: https://github.com/tokio-rs/tracing/blob/4e65750b13721fee7a7ac05b053e1b9c3d21244f/tracing/src/macros.rs#L1698 ## Solution This branch changes the level to `Level::WARN` in the incorrect macro arm. Fixes: #1929 Co-authored-by: Nicolaas Geldenhuys <nicolaas.geldenhuys@cartrack.com>
hawkw
added a commit
that referenced
this pull request
Feb 17, 2022
# 0.1.31 (February 17th, 2022) This release increases the minimum supported Rust version (MSRV) to 1.49.0. In addition, it fixes some relatively rare macro bugs. ### Added - Added `tracing-forest` to the list of related crates ([#1935]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.49.0 ([#1913]) ### Fixed - Fixed the `warn!` macro incorrectly generating an event with the `TRACE` level ([#1930]) - Fixed macro hygiene issues when used in a crate that defines its own `concat!` macro, for real this time ([#1918]) Thanks to @QnnOkabayashi, @nicolaasg, and @teohhanhui for contributing to this release! [#1935]: #1935 [#1913]: #1913 [#1930]: #1930 [#1918]: #1918
hawkw
added a commit
that referenced
this pull request
Feb 17, 2022
# 0.1.31 (February 17th, 2022) This release increases the minimum supported Rust version (MSRV) to 1.49.0. In addition, it fixes some relatively rare macro bugs. ### Added - Added `tracing-forest` to the list of related crates ([#1935]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.49.0 ([#1913]) ### Fixed - Fixed the `warn!` macro incorrectly generating an event with the `TRACE` level ([#1930]) - Fixed macro hygiene issues when used in a crate that defines its own `concat!` macro, for real this time ([#1918]) Thanks to @QnnOkabayashi, @nicolaasg, and @teohhanhui for contributing to this release! [#1935]: #1935 [#1913]: #1913 [#1930]: #1930 [#1918]: #1918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracing: Fix wrong log level in warn macro
Fixes: #1929