docs: build Netlify docs with --all-features
#1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs.rs documentation is built with `--all-features` enabled. However, the netlify docs build does not enable default-off feature flags. This means the docs may not match what's built on docs.rs, and in some cases also results in docs build _failures_ when documentation links to code that's behind an off-by-default feature flag. This commit changes the Netlify settings to enable all features.
hawkw
added a commit
that referenced
this pull request
Dec 29, 2021
## Motivation The docs.rs documentation is built with `--all-features` enabled. However, the Netlify docs build does not enable default-off feature flags. This means the docs may not match what's built on docs.rs, and in some cases also results in docs build _failures_ when documentation links to code that's behind an off-by-default feature flag. ## Solution This commit changes the Netlify settings to enable all features.
hawkw
added a commit
that referenced
this pull request
Dec 29, 2021
## Motivation The docs.rs documentation is built with `--all-features` enabled. However, the Netlify docs build does not enable default-off feature flags. This means the docs may not match what's built on docs.rs, and in some cases also results in docs build _failures_ when documentation links to code that's behind an off-by-default feature flag. ## Solution This commit changes the Netlify settings to enable all features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The docs.rs documentation is built with
--all-featuresenabled.However, the Netlify docs build does not enable default-off feature
flags. This means the docs may not match what's built on docs.rs, and in
some cases also results in docs build failures when documentation
links to code that's behind an off-by-default feature flag.
Solution
This commit changes the Netlify settings to enable all features.