Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriber: clarify the provenance of fmt/time/datetime.rs #1712

Merged
merged 3 commits into from Nov 12, 2021
Merged

subscriber: clarify the provenance of fmt/time/datetime.rs #1712

merged 3 commits into from Nov 12, 2021

Conversation

krasimirgg
Copy link
Contributor

Add comments to clarify the provenance of fmt/time/datetime.rs, addressing #1644.

@krasimirgg krasimirgg marked this pull request as ready for review November 9, 2021 16:29
@krasimirgg krasimirgg requested review from davidbarsky, hawkw and a team as code owners November 9, 2021 16:29
danburkert
danburkert approved these changes Nov 9, 2021
View reviewed changes
Copy link

@danburkert danburkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is consistent with my understanding of the code provenance!

hawkw
hawkw approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. i think it might be more correct to move the copyright notice out of the struct's doc comment, but i won't block on that.

tracing-subscriber/src/fmt/time/datetime.rs Outdated Show resolved Hide resolved
hawkw
hawkw approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@hawkw hawkw merged commit c6055aa into tokio-rs:master Nov 12, 2021
@krasimirgg krasimirgg deleted the datetime-lic branch November 18, 2021 11:22
@krasimirgg
Copy link
Contributor Author

Could you also please update the 0.2.x and 0.3.x minor versions of this crate over at crates.io.

hawkw pushed a commit that referenced this pull request Nov 20, 2021
@krasimirgg @hawkw
subscriber: clarify the provenance of fmt/time/datetime.rs (#1712)
f1e1d99 
Add comments to clarify the provenance of `fmt/time/datetime.rs`,
addressing #1644.

Fixes #1644
hawkw pushed a commit that referenced this pull request Nov 20, 2021
@krasimirgg @hawkw
subscriber: clarify the provenance of fmt/time/datetime.rs (#1712)
8c2852a 
Add comments to clarify the provenance of `fmt/time/datetime.rs`,
addressing #1644.

Fixes #1644
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danburkert danburkert danburkert approved these changes

@hawkw hawkw hawkw approved these changes

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krasimirgg @danburkert @hawkw